RETAIN ignored on Windows platforms

[jgoehringer]

The determination of the variable fileBaseName (line 65) depends on forward slash being the path separator. Tested using path.sep instead of '/'; yields expected results.

[maxime-helen-sb]

Same for me. Would it be possible to have this fix to master? I don't know how to ask pm2 to use my own fork of log rotate as a plugin. I tried to create a PR but I have no permissions as expected.

[NitayRabi]

Same Here. - logs are never deleted, seems to retain an infinite amount of files over time.

[cuteboi]

Same here, on FreeBSD, but I'm getting an error as well. I'll create a new report for that.

[NoorAbdulhameed]

This issue is produced on "pm2-logrotate@2.7.0", in app.js file the "path.sep" is not used; instated the code still uses the forward slash '/' which does not work on Windows

** I used "pm2 install pm2-logrotate" to install the module on PM2 and the "retain" config did not work, log files just kept piling beyond the value of "retain", when I checked the app.js file under pm2-logrotate, the file still uses the '/' separator, the below code snippet taken from the app.js file:

var fileBaseName = file.substr(0, file.length - 4).split(**'/'**).pop() + "__";

hence the fix in #111 does not apply to version @2.7.0

is the pull request #154 planned to be merged to version 2.7.0 any time soon as it should fix the issue?

[Karrlllis]

Hi

Is there plan to merge in fix?

[mycharoka]

does the log keep on piling up even with retain being set?

[PLCs7]

Good morning,
I noticed that in the pm2-logrotate repository, the following line is still present in app.js:

var fileBaseName = file.substr(0, file.length - 4).split('/').pop() + "__";

Could you consider merging the proposed fix into the master branch to enable proper file deletion on Windows as well?

Thank you.