Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minification can break some javascripts #325

Open
orlitzky opened this issue Feb 22, 2023 · 0 comments
Open

Minification can break some javascripts #325

orlitzky opened this issue Feb 22, 2023 · 0 comments

Comments

@orlitzky
Copy link
Contributor

With javascript minification enabled, the slider on the homepage of https://www.txindependencehealthplan.com/ no longer works.

I've taken a look at the code, and I don't really think this can be fixed easily. In this one instance, sure -- maybe. But the root of the issue is that regular expressions can't reliably parse html and javascript. (See e.g. https://stackoverflow.com/questions/6751105/why-its-not-possible-to-use-regex-to-parse-html-xml-a-formal-explanation-in-la for an explanation).

Would you be open to a warning on the settings page saying that the feature uses a regex heuristic and can affect the behavior of the site in some cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant