-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symfony 5 Demo #14
Comments
Yes, definitely both version should be supported. |
Can I submit a PR and then can you create a branch from that? I'm not very
good with git and branches, kinda just fumble through it.
I checked in some files that don't belong in the demo, I can remove them
before I submit a PR.
…On Thu, Apr 30, 2020 at 11:52 AM Kevin Papst ***@***.***> wrote:
Yes, definitely both version should be supported.
I assume that most users still use Symfony 4 and I want to demo that.
But having a second branch would work.
I can create one and you send a PR against that branch?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#14 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEXIQPQ2V7NA2HMFJEYNFTRPGNE7ANCNFSM4MTWNGFA>
.
|
Hi. I can't install the Demo application on Symfony 5. It throws many errors starting with:
yarn install v1.22.10 Can you please help me with suggestions? |
Hi @victorarocha , |
I've updated my fork of this repo to Symfony5. Not sure the best way to submit a PR for this, but here it is for testing and feedback:
https://github.com/tacman/AdminLTEBundle-Demo/tree/symfony5
The significant differences:
@kevinpapst Do you want to support both Symfony 4 and Symfony 5 demos?
The text was updated successfully, but these errors were encountered: