Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl_random_pseudo_bytes missing security check #2

Open
kw-pr opened this issue Jan 9, 2020 · 0 comments
Open

openssl_random_pseudo_bytes missing security check #2

kw-pr opened this issue Jan 9, 2020 · 0 comments

Comments

@kw-pr
Copy link

kw-pr commented Jan 9, 2020

public/OTP/Config/Database.php:62

 $code = bin2hex(openssl_random_pseudo_bytes($codeLength));

The IV generated can be false, please add necessary checks.
Use 2nd parameter for determining if the algorithm used was cryptographically strong.

Like you did in public/OTP/Config/Encryption.php:69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant