Implements Netty Thread-local object pool for Command #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuhuynh27
changed the title
From the post answers, looks like it degrades heavily when the number of distinct string increase, can u explain a bit why we should use string.intern()? All the parameter/argument strings are very likely to be distinct. |
|
Sure @axblueblader, like what you said, I'm considering to revert the commit, not to use |
tuhuynh27
force-pushed
the
feature/object-pool
branch
from
d951e33
to
91f809d
Compare
tuhuynh27
changed the title
|
Regarding the Object Pool, we will release the object right after done processing Command, for AOF mode, will release after the command is flushed to disk (batches) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commandnow will be reused, fixes #69