Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sequence_length option in CLIPTokenizer #2031

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix sequence_length option in CLIPTokenizer #2031

wants to merge 1 commit into from

Conversation

james77777778
Copy link
Collaborator

Fix #2018

There is a bug in CLIPTokenizer where specifying sequence_length causes it to incorrectly use tf.RaggedTensor.to_tensor for padding, instead of self.pad_token_id.
Additionally, we need to compute padding_mask manually rather than relying on tf.RaggedTensor.to_tensor for the same reason.

This PR resolves the issue.

@james77777778 james77777778 mentioned this pull request Dec 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLIPTokenizer does not work as expected
1 participant
@james77777778