Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make use of the insecureSkipTlsVerify in the prometheus basicAuthRoundTripper #3712

Open
odubajDT opened this issue Aug 27, 2024 · 6 comments · May be fixed by #3742
Open

Make use of the insecureSkipTlsVerify in the prometheus basicAuthRoundTripper #3712

odubajDT opened this issue Aug 27, 2024 · 6 comments · May be fixed by #3742
Assignees
@Bharadwajshivam28
Labels
enhancement New feature or request good first issue Good for newcomers metrics-operator status: in-progress

Comments

@odubajDT
Copy link
Contributor

odubajDT commented Aug 27, 2024 •
edited
Loading

In the current implementation, Keptn is using the basicAuthRoundTripper for creating a http client which is able to skip the TLS verification.

We should make use of the already existing parameter and instead of using the DefaultRoundTripper, we should create a custom one with the usage of the insecureSkipTlsVerify parameter in its config. This way, we should be able to use the value of the parameter in the used roudTripper and enable the user to skip/not skip the TLS verification.
@odubajDT odubajDT added enhancement New feature or request metrics-operator labels Aug 27, 2024
@mowies mowies added the status: ready-for-refinement Issue is relevant for the next backlog refinment label Aug 27, 2024
@odubajDT odubajDT mentioned this issue Aug 27, 2024
Merged
@mowies mowies added status: todo good first issue Good for newcomers and removed status: ready-for-refinement Issue is relevant for the next backlog refinment labels Oct 2, 2024
@Bharadwajshivam28
Copy link
Contributor

Hey @mowies I would love to work on this

@odubajDT
Copy link
Contributor Author

odubajDT commented Oct 4, 2024

Hello @Bharadwajshivam28! Thank, you, assigned!

@Bharadwajshivam28
Copy link
Contributor

Hello @Bharadwajshivam28! Thank, you, assigned!

Thanks

@Bharadwajshivam28 Bharadwajshivam28 linked a pull request Oct 5, 2024 that will close this issue
Open
@odubajDT odubajDT changed the title Use more advanced prometheus client to fetch metrics Make use of the insecureSkipTlsVerify in the prometheus basicAuthRoundTripper Oct 9, 2024
@odubajDT
Copy link
Contributor Author

odubajDT commented Oct 9, 2024

Hey @Bharadwajshivam28 thank you for the PR, unfortunately we found out that there is no need to use the TLSRoundTripper for the prometheus provider to actually enable skipping the tls verification. It should be enough just to adapt the configuration of the currently used basicRoundTripper. I adapted the description of the ticket for more guidance.

Sorry for the requirement changes!

@Bharadwajshivam28
Copy link
Contributor

Hey @Bharadwajshivam28 thank you for the PR, unfortunately we found out that there is no need to use the TLSRoundTripper for the prometheus provider to actually enable skipping the tls verification. It should be enough just to adapt the configuration of the currently used basicRoundTripper. I adapted the description of the ticket for more guidance.

Sorry for the requirement changes!

okay I have seen the description and will make changes in the codebase accordingly

@github-actions GitHub Actions
Copy link
Contributor

This issue will be unassigned in 1 week if no further activity is seen.
If you are active please provide an update on the status of the issue and if you would like to continue
working on it.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 8, 2024
@mowies mowies reopened this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bharadwajshivam28 Bharadwajshivam28

Labels
enhancement New feature or request good first issue Good for newcomers metrics-operator status: in-progress
Projects
Keptn Lifecycle Toolkit
Status: ✅ Done
Milestone
No milestone
3 participants
@mowies @odubajDT @Bharadwajshivam28