Skip to content

Commit 7bf07cb

Browse files
gitchenjhgitee-org
authored andcommitted
!286 修复远程文件,文件名带有穿越的BUG
Merge pull request !286 from 高雄/chuanyue
2 parents ab370e6 + b65a048 commit 7bf07cb

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

server/src/main/java/cn/keking/utils/WebUtils.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,9 @@ public static String urlEncoderencode(String urlStr) {
7979
urlStr = clearFullfilenameParam(urlStr);
8080
} else {
8181
fullFileName = getFileNameFromURL(urlStr); //获取文件名
82-
82+
}
83+
if (KkFileUtils.isIllegalFileName(fullFileName)) { //判断文件名是否带有穿越漏洞
84+
return null;
8385
}
8486
if (!UrlEncoderUtils.hasUrlEncoded(fullFileName)) { //判断文件名是否转义
8587
try {

server/src/main/java/cn/keking/web/controller/OnlinePreviewController.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import org.springframework.http.client.HttpComponentsClientHttpRequestFactory;
2222
import org.springframework.stereotype.Controller;
2323
import org.springframework.ui.Model;
24+
import org.springframework.util.ObjectUtils;
2425
import org.springframework.util.StringUtils;
2526
import org.springframework.web.bind.annotation.GetMapping;
2627
import org.springframework.web.bind.annotation.ResponseBody;
@@ -76,7 +77,11 @@ public String onlinePreview(String url, Model model, HttpServletRequest req) {
7677
model.addAttribute("file", fileAttribute);
7778
FilePreview filePreview = previewFactory.get(fileAttribute);
7879
logger.info("预览文件url:{},previewType:{}", fileUrl, fileAttribute.getType());
79-
return filePreview.filePreviewHandle(WebUtils.urlEncoderencode(fileUrl), model, fileAttribute); //统一在这里处理 url
80+
fileUrl =WebUtils.urlEncoderencode(fileUrl);
81+
if (ObjectUtils.isEmpty(fileUrl)) {
82+
return otherFilePreview.notSupportedFile(model, "非法路径,不允许访问");
83+
}
84+
return filePreview.filePreviewHandle(fileUrl, model, fileAttribute); //统一在这里处理 url
8085
}
8186

8287
@GetMapping( "/picturesPreview")

0 commit comments

Comments
 (0)