-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MangaThemesia] Option to hide paid chapters #6598
[MangaThemesia] Option to hide paid chapters #6598
Conversation
I don't think this needs to be in |
Two out of the three sources using the To be honest I still don't fully understand what |
Alt version have additional logic for dynamic urls (random part in manga url which changes every so often) |
I see a few ways forward here, so I'm writing them out here to get your thoughts:
I'm leaning towards (2), I'll throw together an implementation and see how it looks. |
Updated and bench tested. How does this implementation look @AwkwardPeak7 ? |
honestly just change selector in those sources to block paid chapters without any preference to toggle it.... that is what we usually do for most of such sources and only add preference if users ask for it. |
I've actually been finding the toggle useful, some of these sites have decent coin rates where it's only like 10 cents per chapter, so on some of them I actually do want to leave the toggle off and buy the chapters. |
Two of the sources using the
MangaThemesiaAlt
theme, NightScans and ThunderScans, have paid chapters which cannot be viewed in Mihon without purchasing (attempting to click them results in an error). This PR hides those chapters from the chapter list. It also adds a setting to go back to the old behavior of not hiding them (a user might want to use this, for example, to be notified when there are new paid chapters so that they can go and purchase them on the scanlator's website), but the default setting is to hide them.Closes #5908
Checklist:
extVersionCode
value inbuild.gradle
for individual extensionsoverrideVersionCode
orbaseVersionCode
as needed for all multisrc extensionsoverrideVersionCode
for extensions that we added functionality to. ThebaseVersionCode
does not need to be updated since we only added a new file to the multisource library, we didn't do anything that would affect existing extensions using the library.isNsfw = true
flag inbuild.gradle
when appropriateid
if a source's name or language were changedweb_hi_res_512.png
when adding a new extensionThe new setting option:
With hiding enabled:
With hiding disabled:
(Also confirmed that after logging in with web view and purchasing chapters, they do show up even if hiding is enabled)