Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout feature during conformer generation #34

Open
wujinkui opened this issue Jul 22, 2019 · 2 comments
Open

Add timeout feature during conformer generation #34

wujinkui opened this issue Jul 22, 2019 · 2 comments

Comments

@wujinkui
Copy link

wujinkui commented Jul 22, 2019

Dear professors: When I used the function fprints_from_smiles in e3fp, it cost much time to find the conformers if there were none. For example, I wanted to get the fingerprint of A, it cost 10 minutes to find the conforms, and it returned error at last. So, I suggest that you could add a function named Timeout in the function to avoid the situation

@wujinkui wujinkui reopened this Jul 22, 2019
@wujinkui wujinkui changed the title Dear professors: Dear professors: When I used the function fprints_from_smiles in e3fp, it cost much time to find the conformers if there were none. For example, I wanted to get the fingerprint of A, it cost 10 minutes to find the conforms, and it returned error at last. So, I suggest that you could add a function named Timeout in the function to avoid the situation Jul 22, 2019
@sethaxen sethaxen changed the title Dear professors: When I used the function fprints_from_smiles in e3fp, it cost much time to find the conformers if there were none. For example, I wanted to get the fingerprint of A, it cost 10 minutes to find the conforms, and it returned error at last. So, I suggest that you could add a function named Timeout in the function to avoid the situation Add timeout feature during conformer generation Jul 22, 2019
@sethaxen
Copy link
Collaborator

We tried to add a timeout feature when e3fp was first released, but at the time, there wasn't a good way to do this in Python. It's worth revisiting to see if the language or a package has provided this feature since then.

In the meantime, if you could provide the molecule that you're having difficulty with, we could check to see if the issue is some trivial bug.

@wujinkui
Copy link
Author

wujinkui commented Jul 22, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants