Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implemented ServiceNow provider to fetch and ingest incidents into Keep #1302

Closed
wants to merge 10 commits into from
Closed

Conversation

Anshgrover23
Copy link

/claim #1261

Description

This PR introduces a new provider for integrating ServiceNow's ITSM incidents into Keep. It fetches incidents using the ServiceNow Table API and ingests them into Keep as events.

Fixes

Fixes #1261

Changes Made

  • Implemented ServiceNowProvider class to handle authentication and data retrieval.
  • Added functions to fetch incidents from ServiceNow and transform them into Keep events.
  • Updated README.md with setup instructions and usage examples.

Testing

  • Added unit tests for ServiceNowProvider to ensure proper data retrieval and transformation.
  • Ran tests locally to verify functionality.

Additional Notes

  • ServiceNow API integration is complex; detailed documentation is provided to assist future maintenance.

Copy link

vercel bot commented Jun 27, 2024

@Anshgrover23 is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Jun 27, 2024

CLA assistant check
All committers have signed the CLA.

@Anshgrover23 Anshgrover23 changed the title Implemented ServiceNow provider to fetch and ingest incidents into Keep feat: Implemented ServiceNow provider to fetch and ingest incidents into Keep Jun 27, 2024
Copy link

@unworld11 unworld11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ingest_into_keep is incomplete,
if you chatgpt it, atleast crosscheck the code :)

@Anshgrover23
Copy link
Author

@unworld11 what's your problem mam? Even you have chatgpt the problem I think you are more of jealous than solving the issue because I have taken your attempt of bounty you are getting jealous. I am waiting for the maintainer to reply not you.

@unworld11
Copy link

your code is incomplete ansh.
i am literally helping you,
you can crosscheck your code and the function i am talking about,
i don't mind the claim.
just making sure yk how open source works, it's barely about the bounty.
#buildinpublic :)

@Anshgrover23
Copy link
Author

@unworld11 sorry bro, if you want you can take bounty. I am new to open source I don't know about these and I will take your advice politely and thanks for helping me brother. And sorry for my comment

@shahargl
Copy link
Member

@Anshgrover23 hey bro, why did you remove all the comments from the code? it is very hard to understand what are the real code changes and what are not. Can you revert these changes so I'll be able to review only relevant code?

@shahargl shahargl self-requested a review June 29, 2024 14:58
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@Anshgrover23
Copy link
Author

@shahargl i am doing undone the comments

@Anshgrover23
Copy link
Author

@shahargl check done reapplied all the comments removed by mistake

Signed-off-by: Anshgrover23 <[email protected]>
@Anshgrover23 Anshgrover23 requested a review from shahargl June 29, 2024 17:04
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm closing this PR now since it is not ready

@shahargl
Copy link
Member

Closing until @Anshgrover23 will have end to end working.

@shahargl shahargl closed this Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🔌 Provider]: ServiceNow ITSM
4 participants