-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implemented ServiceNow provider to fetch and ingest incidents into Keep #1302
Conversation
@Anshgrover23 is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ingest_into_keep is incomplete,
if you chatgpt it, atleast crosscheck the code :)
@unworld11 what's your problem mam? Even you have chatgpt the problem I think you are more of jealous than solving the issue because I have taken your attempt of bounty you are getting jealous. I am waiting for the maintainer to reply not you. |
your code is incomplete ansh. |
@unworld11 sorry bro, if you want you can take bounty. I am new to open source I don't know about these and I will take your advice politely and thanks for helping me brother. And sorry for my comment |
@Anshgrover23 hey bro, why did you remove all the comments from the code? it is very hard to understand what are the real code changes and what are not. Can you revert these changes so I'll be able to review only relevant code? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
@shahargl i am doing undone the comments |
@shahargl check done reapplied all the comments removed by mistake |
Signed-off-by: Anshgrover23 <[email protected]>
Signed-off-by: Anshgrover23 <[email protected]>
Signed-off-by: Anshgrover23 <[email protected]>
Signed-off-by: Anshgrover23 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm closing this PR now since it is not ready
Closing until @Anshgrover23 will have end to end working. |
/claim #1261
Description
This PR introduces a new provider for integrating ServiceNow's ITSM incidents into Keep. It fetches incidents using the ServiceNow Table API and ingests them into Keep as events.
Fixes
Fixes #1261
Changes Made
Testing
Additional Notes