Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasets ListAllDefinitions corner cases #132

Open
masojus opened this issue Nov 4, 2017 · 1 comment
Open

Datasets ListAllDefinitions corner cases #132

masojus opened this issue Nov 4, 2017 · 1 comment

Comments

@masojus
Copy link
Contributor

masojus commented Nov 4, 2017

From review comments:

I just wonder what happens if the first request can give us a Count that can change by the time we 
request a later page...say I request 10 defs, the Count is 15, so we request another 10 or 5 or whatever, 
 but since then another couple datasets have been added. We could potentially stop if we get 20 since 
it's >15, even if there are now actually 30 datasets because a bunch got added.

Likewise, if we request 10, the Count is 15, and before we request another page, some datasets get 
deleted, then we request another 10, but since 5 have been deleted, we get 0 back...according to the 
check above we'll throw even though this is technically correct.

I'll probably open a bug to handle these two cases since they'll require some deeper testing and 
knowing how the back end will actually behave, plus they are somewhat corner cases, so aren't on the 
critical path to getting this functionality usable. Grabbing the the most recent result set's Count instead 
of the first will help, but we'll have to keep a running tab of what's left and potentially tolerate an empty 
result set.
@masojus masojus mentioned this issue Nov 4, 2017
@masojus
Copy link
Contributor Author

masojus commented Nov 4, 2017

We should also enforce the limit of 100 definitions in a page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant