Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeenQueryTestBase lower-level HTTP Request validation #100

Open
masojus opened this issue May 17, 2017 · 0 comments
Open

KeenQueryTestBase lower-level HTTP Request validation #100

masojus opened this issue May 17, 2017 · 0 comments

Comments

@masojus
Copy link
Collaborator

masojus commented May 17, 2017

We should work on making it easier to do lower-level validation of HTTP requests in the query tests. KeenQueryTestBase might be a good place to share this functionality since this is where we have the shared code to mock and capture requests and responses.

From PR #96:

    // TODO : Add a means to check more about the lower-level HTTP request, like the specific
    // headers, URL, response codes, etc. Both the DELETE and GET requests have no request body
    // so everything is in the URL/headers. KeenQueryTest does this in some places.

...and...

    // TODO : We should add some verification of the actual URL produced in the Request
    // the way we do in some of the tests in KeenQueryTest.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant