tests (internal-api-client): listing jobs with branchType = null

Author: MiroCillik

tests/ClientFunctionalTest.php

@@ -5,11 +5,11 @@
 namespace Keboola\JobQueueInternalClient\Tests;
 
 use DateTimeImmutable;
-use Keboola\JobQueueInternalClient\Client;
 use Keboola\JobQueueInternalClient\Exception\ClientException;
 use Keboola\JobQueueInternalClient\Exception\StateTargetEqualsCurrentException;
 use Keboola\JobQueueInternalClient\JobFactory\Job;
 use Keboola\JobQueueInternalClient\JobFactory\JobInterface;
+use Keboola\JobQueueInternalClient\JobFactory\ObjectEncryptor\JobObjectEncryptor;
 use Keboola\JobQueueInternalClient\JobListOptions;
 use Keboola\JobQueueInternalClient\JobPatchData;
 use Keboola\JobQueueInternalClient\JobsSortOptions;
@@ -19,7 +19,7 @@
 use Keboola\StorageApi\Components;
 use Keboola\StorageApi\DevBranches;
 use Keboola\StorageApi\Options\Components\Configuration;
-use Psr\Log\NullLogger;
+use Keboola\StorageApiBranch\Factory\StorageClientPlainFactory;
 
 class ClientFunctionalTest extends BaseClientFunctionalTest
 {
@@ -537,6 +537,40 @@ public function testListJobsByComponent(): void
         self::assertCount(2, $response);
     }
 
+    public function testListJobsWithBranchTypeNull(): void
+    {
+        // jobs before branchType has branchType = null
+        $newJobFactory = $this->getNewJobFactory();
+        $client = $this->getClient();
+
+        $job = $newJobFactory->createNewJob([
+            '#tokenString' => getenv('TEST_STORAGE_API_TOKEN'),
+            'configId' => self::$configId1,
+            'componentId' => self::COMPONENT_ID_1,
+            'mode' => 'run',
+        ]);
+        $jobData = array_merge($job->jsonSerialize(), ['branchType' => null]);
+
+        $objectEncryptor = $this->createMock(JobObjectEncryptor::class);
+        $storageClientFactory = $this->createMock(StorageClientPlainFactory::class);
+
+        $jobWithBranchTypeNull = new Job($objectEncryptor, $storageClientFactory, $jobData);
+
+        $createdJob = $client->createJob($jobWithBranchTypeNull);
+
+        // list one component
+        $response = $client->listJobs(
+            (new JobListOptions())
+                ->setStatuses([JobInterface::STATUS_CREATED]),
+            true
+        );
+        self::assertCount(1, $response);
+        /** @var Job $listedJob */
+        $listedJob = $response[0];
+        self::assertEquals($createdJob->jsonSerialize(), $listedJob->jsonSerialize());
+        self::assertNull($listedJob->getBranchType());
+    }
+
     public function testListJobsSort(): void
     {
         $newJobFactory = $this->getNewJobFactory();