Merge pull request #158 from keboola/pepa_PS-3697_isLegacyComponent

PS-3697 Get rid of Job::isLegacyComponent, not needed anymore

Author: pepamartinec

src/JobFactory.php

@@ -102,11 +102,6 @@ public static function getAllowedParallelismValues(): array
         return array_merge($intValues, ['infinity', null]);
     }
 
-    public static function getLegacyComponents(): array
-    {
-        return ['orchestrator', 'transformation', 'provisioning'];
-    }
-
     public function createNewJob(array $data): JobInterface
     {
         $data = $this->validateJobData($data, NewJobDefinition::class);

src/JobFactory/Job.php

@@ -235,11 +235,6 @@ private function decryptData($data)
         );
     }
 
-    public function isLegacyComponent(): bool
-    {
-        return empty($this->getComponentId()) || in_array($this->getComponentId(), JobFactory::getLegacyComponents());
-    }
-
     public function getBranchId(): ?string
     {
         return $this->data['branchId'] ?? null;

src/JobFactory/JobInterface.php

@@ -39,7 +39,6 @@ public function getBehavior(): Behavior;
     public function jsonSerialize(): array;
     public function getTokenDecrypted(): string;
     public function getConfigDataDecrypted(): array;
-    public function isLegacyComponent(): bool;
     public function getBranchId(): ?string;
     public function getVariableValuesId(): ?string;
     public function getVariableValuesData(): array;

tests/JobFactory/JobTest.php

@@ -195,27 +195,6 @@ public function testHasVariables(): void
         self::assertSame(false, $job->hasVariables());
     }
 
-    public function testIsLegacy(): void
-    {
-        self::assertFalse($this->getJob()->isLegacyComponent());
-    }
-
-    public function testIsLegacyOrchestrator(): void
-    {
-        $jobData = $this->jobData;
-        $jobData['componentId'] = 'orchestrator';
-        self::assertTrue($this->getJob($jobData)->isLegacyComponent());
-    }
-
-    public function testLegacyOrchestratorJob(): void
-    {
-        $jobData = $this->jobData;
-        unset($jobData['componentId']);
-        $job = $this->getJob($jobData);
-        self::assertEquals('', $job->getComponentId());
-        self::assertTrue($job->isLegacyComponent());
-    }
-
     public function testJsonSerialize(): void
     {
         $expected = $this->jobData;

tests/JobFactoryTest.php

@@ -526,7 +526,6 @@ public function testStaticGetters(): void
     {
         self::assertCount(5, JobFactory::getFinishedStatuses());
         self::assertCount(9, JobFactory::getAllStatuses());
-        self::assertCount(3, JobFactory::getLegacyComponents());
         self::assertCount(3, JobFactory::getKillableStatuses());
     }