Skip to content

Commit 8717d26

Browse files
authored
Merge pull request #295 from keboola/odin-SOX-193
Fix execution token permissisons
2 parents 0df75d2 + fa78d0f commit 8717d26

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

src/JobFactory/Job.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -378,6 +378,9 @@ private function createPrivilegedToken(string $applicationToken): string
378378
{
379379
$tokens = new Tokens($this->getStorageClientWrapper()->getBasicClient());
380380
$options = new TokenCreateOptions();
381+
$options->setDescription(sprintf('Execution Token for job %s', $this->getId()));
382+
$options->setCanManageBuckets(true);
383+
$options->setCanReadAllFileUploads(true);
381384
$options->setExpiresIn(self::EXECUTION_TOKEN_TIMEOUT_SECONDS);
382385
$token = $tokens->createTokenPrivilegedInProtectedDefaultBranch($options, $applicationToken);
383386

tests/JobFactory/JobTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -829,6 +829,9 @@ public function testGetExecutionTokenDecryptedWithFeatureBranchDefault(): void
829829
[
830830
'canManageProtectedDefaultBranch' => true,
831831
'expiresIn' => 604800,
832+
'description' => 'Execution Token for job 123456456',
833+
'canReadAllFileUploads' => true,
834+
'canManageBuckets' => true,
832835
],
833836
$applicationToken
834837
)

0 commit comments

Comments
 (0)