Merge pull request #385 from keboola/miro-PST-1343

PST-1343: ComponentDefinition new fields

Author: MiroCillik

src/JobFactory/Configuration/ComponentDefinition.php

@@ -58,6 +58,24 @@ protected function getRootDefinition(TreeBuilder $treeBuilder): ArrayNodeDefinit
                 ->scalarPrototype()->end()
                 ->defaultValue([])
             ->end()
+            ->arrayNode('dataTypesConfiguration')
+                ->ignoreExtraKeys()
+                ->children()
+                    ->enumNode('dataTypesSupport')
+                        ->values(['none', 'authoritative', 'hints'])
+                        ->defaultValue('none')
+                    ->end()
+                ->end()
+            ->end()
+            ->arrayNode('processorConfiguration')
+                ->ignoreExtraKeys()
+                ->children()
+                    ->enumNode('allowedProcessorPosition')
+                        ->values(['any', 'before', 'after'])
+                        ->defaultValue('any')
+                    ->end()
+                ->end()
+            ->end()
             ->arrayNode('data')->isRequired()
                 ->children()
                     ->arrayNode('definition')->isRequired()

tests/JobFactory/Configuration/ComponentDefinitionTest.php

@@ -127,6 +127,14 @@ public function validDataProvider(): Generator
                 'features' => [
                     'some-feature',
                 ],
+                'dataTypesConfiguration' => [
+                    'dataTypesSupport' => 'hints',
+                    'somethingElse' => 'should be ignored',
+                ],
+                'processorConfiguration' => [
+                    'allowedProcessorPosition' => 'after',
+                    'somethingElse' => 'should be ignored',
+                ],
             ],
             'expected' => [
                 'id' => 'test',
@@ -178,6 +186,12 @@ public function validDataProvider(): Generator
                 'features' => [
                     'some-feature',
                 ],
+                'dataTypesConfiguration' => [
+                    'dataTypesSupport' => 'hints',
+                ],
+                'processorConfiguration' => [
+                    'allowedProcessorPosition' => 'after',
+                ],
             ],
         ];
         yield 'other options' => [
@@ -412,5 +426,37 @@ public function invalidDataProvider(): Generator
             'expected' => 'The value -1 is too small for path "component.data.process_timeout". ' .
                 'Should be greater than or equal to 0',
         ];
+        yield 'invalid dataTypeSupport' => [
+            'data' => [
+                'id' => 'test',
+                'data' => [
+                    'definition' => [
+                        'type' => 'aws-ecr',
+                        'uri' => 'some-uri',
+                    ],
+                ],
+                'dataTypesConfiguration' => [
+                    'dataTypesSupport' => 'invalid',
+                ],
+            ],
+            'expected' => 'The value "invalid" is not allowed for path ' .
+                '"component.dataTypesConfiguration.dataTypesSupport"',
+        ];
+        yield 'invalid allowedProcessorPosition' => [
+            'data' => [
+                'id' => 'test',
+                'data' => [
+                    'definition' => [
+                        'type' => 'aws-ecr',
+                        'uri' => 'some-uri',
+                    ],
+                ],
+                'processorConfiguration' => [
+                    'allowedProcessorPosition' => 'invalid',
+                ],
+            ],
+            'expected' => 'The value "invalid" is not allowed for path ' .
+                '"component.processorConfiguration.allowedProcessorPosition"',
+        ];
     }
 }