Merge pull request #235 from keboola/erik-PST-402

JobDefinition - ignoreExtraKeys for backend

Author: odinuv

src/JobFactory/FullJobDefinition.php

@@ -171,7 +171,7 @@ protected function getRootDefinition(TreeBuilder $treeBuilder): ArrayNodeDefinit
                         ->end()
                     ->end()
                     ->children()
-                        ->arrayNode('backend')
+                        ->arrayNode('backend')->ignoreExtraKeys(true)
                             ->children()
                                 ->scalarNode('size')->end()
                                 ->scalarNode('containerSize')->end()

src/JobFactory/NewJobDefinition.php

@@ -68,7 +68,7 @@ protected function getRootDefinition(TreeBuilder $treeBuilder): ArrayNodeDefinit
                         ->end()
                     ->end()
                 ->end()
-                ->arrayNode('backend')->ignoreExtraKeys(false)
+                ->arrayNode('backend')->ignoreExtraKeys(true)
                     ->children()
                         ->scalarNode('type')->end()
                         ->scalarNode('containerType')->end()

tests/JobFactory/FullJobDefinitionTest.php

@@ -74,6 +74,7 @@ public function testValidJobFull(): void
                 'type' => 'large',
                 'containerType' => 'small',
                 'context' => 'wml',
+                'backendExtraKey' => 'ignored',
             ],
             'metrics' => [
                 'storage' => [
@@ -92,6 +93,7 @@ public function testValidJobFull(): void
             'runnerId' => $runnerId,
         ];
         unset($data['extraKey']);
+        unset($data['backend']['backendExtraKey']);
         unset($data['metrics']['storage']['storageExtraKey']);
         unset($data['metrics']['backend']['backendExtraKey']);
         $definition = new FullJobDefinition();

tests/JobFactory/NewJobDefinitionTest.php

@@ -61,12 +61,14 @@ public function testValidJobFull(string $mode): void
                 'type' => 'my',
                 'containerType' => 'his',
                 'context' => 'wml',
-                'foo' => 'bar',
+                'extraKey' => 'ignored',
             ],
             'orchestrationJobId' => '123456789',
         ];
         $definition = new NewJobDefinition();
-        self::assertSame($data, $definition->processData($data));
+        $result = $definition->processData($data);
+        unset($data['backend']['extraKey']);
+        self::assertSame($data, $result);
     }
 
     public function invalidJobProvider(): array