SOX-406 Add validation for unique onlyOrchestrationTaskIds

Author: pepamartinec

src/JobFactory/FullJobDefinition.php

@@ -219,6 +219,10 @@ protected function getRootDefinition(TreeBuilder $treeBuilder): ArrayNodeDefinit
                         ->ifTrue(fn($v) => count(array_filter($v ?? [], fn($i) => $i === '')) > 0)
                         ->thenInvalid('item cannot be empty string')
                     ->end()
+                    ->validate()
+                        ->ifTrue(fn($v) => $v !== null && count($v) !== count(array_unique($v)))
+                        ->thenInvalid('items must be unique')
+                    ->end()
                 ->end()
                 ->scalarNode('previousJobId')
                     ->validate()

src/JobFactory/NewJobDefinition.php

@@ -112,6 +112,10 @@ protected function getRootDefinition(TreeBuilder $treeBuilder): ArrayNodeDefinit
                         ->ifTrue(fn($v) => count(array_filter($v ?? [], fn($i) => $i === '')) > 0)
                         ->thenInvalid('item cannot be empty string')
                     ->end()
+                    ->validate()
+                        ->ifTrue(fn($v) => $v !== null && count($v) !== count(array_unique($v)))
+                        ->thenInvalid('items must be unique')
+                    ->end()
                 ->end()
                 ->scalarNode('previousJobId')
                     ->validate()

tests/JobFactory/FullJobDefinitionTest.php

@@ -521,6 +521,22 @@ public function invalidJobProvider(): array
                 ],
                 '/Invalid configuration for path "job.onlyOrchestrationTaskIds": item cannot be empty string/',
             ],
+            'onlyOrchestrationTaskIds with duplicated item' => [
+                [
+                    '#tokenString' => getenv('TEST_STORAGE_API_TOKEN'),
+                    'id' => '12345',
+                    'runId' => '12345',
+                    'tokenId' => '1234',
+                    'projectId' => '123',
+                    'status' => 'created',
+                    'desiredStatus' => 'processing',
+                    'configId' => '123',
+                    'componentId' => 'keboola.test',
+                    'mode' => 'run',
+                    'onlyOrchestrationTaskIds' => ['11', '22', '11'],
+                ],
+                '/Invalid configuration for path "job.onlyOrchestrationTaskIds": items must be unique/',
+            ],
             'previousJobId not string' => [
                 [
                     '#tokenString' => getenv('TEST_STORAGE_API_TOKEN'),

tests/JobFactory/NewJobDefinitionTest.php

@@ -224,6 +224,16 @@ public function invalidJobProvider(): array
                 ],
                 '/Invalid configuration for path "job.onlyOrchestrationTaskIds": item cannot be empty string/',
             ],
+            'onlyOrchestrationTaskIds with duplicated item' => [
+                [
+                    '#tokenString' => getenv('TEST_STORAGE_API_TOKEN'),
+                    'configId' => '123',
+                    'componentId' => 'keboola.test',
+                    'result' => [],
+                    'onlyOrchestrationTaskIds' => ['11', '22', '11'],
+                ],
+                '/Invalid configuration for path "job.onlyOrchestrationTaskIds": items must be unique/',
+            ],
             'previousJobId not string' => [
                 [
                     '#tokenString' => getenv('TEST_STORAGE_API_TOKEN'),