Merge pull request #541 from keboola/miro-AJDA-231

AJDA-231: allow backend size for keboola.legacy-tran…

Author: MiroCillik

src/JobFactory/JobRuntimeResolver.php

@@ -196,15 +196,19 @@ private function resolveBackend(array $jobData, StorageApiToken $token): Backend
         For workspace size, we only consider 'workspace-snowflake' as it is the only backend supporting scaling.
         During this we ignore any containerType setting received in $tempBackend, which so far is intentional.
         We also ignore backend settings for other workspace types, as they do not make any sense at the moment.
+        Component "keboola.legacy-transformation" supports dynamic backend, but it doesn't have workspace staging.
         */
+        if ($jobData['componentId'] === 'keboola.legacy-transformation') {
+            return new Backend($tempBackend->getType(), null, $backendContext);
+        }
         if (in_array($stagingStorage, ['local', 's3', 'abs', 'none']) &&
             !$token->hasFeature(self::PAY_AS_YOU_GO_FEATURE)
         ) {
             return new Backend(null, $tempBackend->getType(), $backendContext);
         }
         if ($stagingStorage === 'workspace-snowflake') {
-            // dynamic workspace si hidden behind another feature `workspace-snowflake-dynamic-backend-size`
-            // that is checked in SAPI, so we don't check it here, yet
+            // Dynamic workspace si hidden behind another feature `workspace-snowflake-dynamic-backend-size`
+            // that is checked in SAPI, so we don't check it here.
             return new Backend($tempBackend->getType(), null, $backendContext);
         }
         return new Backend(null, null, $backendContext);

tests/JobFactory/JobRuntimeResolverTest.php

@@ -1162,8 +1162,10 @@ public function testResolveBackend(
         ?string $expectedContainerType,
         ?string $expectedContext,
         array $tokenFeatures,
+        string $componentId = 'keboola.ex-db-snowflake',
     ): void {
         $jobData = $this::JOB_DATA;
+        $jobData['componentId'] = $componentId;
         $jobData['configId'] = null;
         $jobData['tag'] = '1.2.3';
         $jobData['variableValuesData'] = [
@@ -1182,7 +1184,7 @@ public function testResolveBackend(
 
         $storageClient = self::createMock(BranchAwareClient::class);
         $storageClient->expects(self::exactly($expectedApiCallCount))->method('apiGet')
-            ->with('components/keboola.ex-db-snowflake')
+            ->with(sprintf('components/%s', $componentId))
             ->willReturn(
                 $this->getTestComponentData($stagingInput),
             );
@@ -1196,7 +1198,7 @@ public function testResolveBackend(
                 'id' => '123456456',
                 'runId' => '123456456',
                 'configId' => null,
-                'componentId' => 'keboola.ex-db-snowflake',
+                'componentId' => $componentId,
                 'mode' => 'run',
                 'status' => 'created',
                 'desiredStatus' => 'processing',
@@ -1400,6 +1402,28 @@ public function backendProvider(): Generator
             null,
             [],
         ];
+        yield 'legacy transformation - large' => [
+            'large',
+            null,
+            'none',
+            1,
+            'large',
+            null,
+            null,
+            [],
+            'keboola.legacy-transformation',
+        ];
+        yield 'legacy transformation - default' => [
+            null,
+            null,
+            'none',
+            1,
+            null,
+            null,
+            null,
+            [],
+            'keboola.legacy-transformation',
+        ];
     }
 
     private function getTestComponentData(?string $stagingInput = 'local'): array