Merge pull request #465 from keboola/pepa_PST-2131_processTimeout

PST-2131 Allow setting custom job timeout using config

Author: pepamartinec

src/JobFactory/OverridesConfigurationDefinition.php

@@ -59,6 +59,13 @@ protected function getRootDefinition(TreeBuilder $treeBuilder): ArrayNodeDefinit
                         ->scalarNode('image_tag')
                             ->beforeNormalization()->always($this->getStringNormalizer())->end()
                         ->end()
+                        ->integerNode('process_timeout')
+                            ->defaultNull()
+                            ->validate()
+                                ->ifTrue(fn($v) => $v !== null && $v <= 0)
+                                ->thenInvalid('must be greater than 0')
+                            ->end()
+                        ->end()
                         ->arrayNode('backend')->ignoreExtraKeys(true)
                             ->children()
                                 ->scalarNode('type')

tests/JobFactory/OverridesConfigurationDefinitionTest.php

@@ -51,6 +51,7 @@ public function testValidOverrideFull(): void
         unset($expected['variableValuesData']['extra']);
         $expected['variableValuesId'] = '123';
         $expected['runtime']['tag'] = '1';
+        $expected['runtime']['process_timeout'] = null;
         $expected['runtime']['parallelism'] = null;
         self::assertSame($expected, $definition->processData($data));
     }
@@ -103,6 +104,33 @@ public function invalidConfigurationProvider(): iterable
             ],
             'message' => '#The value "foo" is not allowed for path "overrides.runtime.executor". Permissible values: null, "dind", "k8sContainers"#',
         ];
+
+        yield 'process_timeout zero' => [
+            'jobData' => [
+                'runtime' => [
+                    'process_timeout' => 0,
+                ],
+            ],
+            'message' => '#^Invalid configuration for path "overrides.runtime.process_timeout": must be greater than 0$#',
+        ];
+
+        yield 'process_timeout negative' => [
+            'jobData' => [
+                'runtime' => [
+                    'process_timeout' => -10,
+                ],
+            ],
+            'message' => '#^Invalid configuration for path "overrides.runtime.process_timeout": must be greater than 0$#',
+        ];
+
+        yield 'process_timeout float' => [
+            'jobData' => [
+                'runtime' => [
+                    'process_timeout' => 10.0,
+                ],
+            ],
+            'message' => '#^Invalid type for path "overrides.runtime.process_timeout". Expected "int", but got "float".$#',
+        ];
         // phpcs:enable Generic.Files.LineLength
     }