Skip to content

Commit 287747d

Browse files
authored
Merge pull request #123 from keboola/erik-PS-3432
internal-api-php-client - staging_storage supports workspace-teradata option
2 parents 609b7d8 + 1e37bcb commit 287747d

File tree

3 files changed

+12
-4
lines changed

3 files changed

+12
-4
lines changed

src/JobFactory/Configuration/ComponentDefinition.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -202,13 +202,13 @@ protected function getRootDefinition(TreeBuilder $treeBuilder): ArrayNodeDefinit
202202
->children()
203203
->enumNode('input')
204204
->values(['local', 's3', 'abs', 'none', 'workspace-snowflake', 'workspace-redshift',
205-
'workspace-synapse', 'workspace-abs', 'workspace-exasol',
205+
'workspace-synapse', 'workspace-abs', 'workspace-exasol', 'workspace-teradata',
206206
])
207207
->defaultValue('local')
208208
->end()
209209
->enumNode('output')
210210
->values(['local', 'none', 'workspace-snowflake', 'workspace-redshift',
211-
'workspace-synapse', 'workspace-abs', 'workspace-exasol',
211+
'workspace-synapse', 'workspace-abs', 'workspace-exasol', 'workspace-teradata',
212212
])
213213
->defaultValue('local')
214214
->end()

tests/JobFactory/Configuration/ComponentDefinitionTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -379,7 +379,7 @@ public function invalidDataProvider(): Generator
379379
],
380380
'expected' => 'The value "invalid" is not allowed for path "component.data.staging_storage.input". ' .
381381
'Permissible values: "local", "s3", "abs", "none", "workspace-snowflake", "workspace-redshift", ' .
382-
'"workspace-synapse", "workspace-abs", "workspace-exasol"',
382+
'"workspace-synapse", "workspace-abs", "workspace-exasol", "workspace-teradata"',
383383
];
384384
yield 'invalid staging output' => [
385385
'data' => [
@@ -396,7 +396,7 @@ public function invalidDataProvider(): Generator
396396
],
397397
'expected' => 'The value "invalid" is not allowed for path "component.data.staging_storage.output". ' .
398398
'Permissible values: "local", "none", "workspace-snowflake", "workspace-redshift", ' .
399-
'"workspace-synapse", "workspace-abs", "workspace-exasol"',
399+
'"workspace-synapse", "workspace-abs", "workspace-exasol", "workspace-teradata"',
400400
];
401401
yield 'invalid process timeout too small' => [
402402
'data' => [

tests/JobFactory/JobRuntimeResolverTest.php

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -985,6 +985,14 @@ public function backendProvider(): Generator
985985
null,
986986
['owner' => ['features' => ['dynamic-backend-jobs']]],
987987
];
988+
yield 'custom workspace-teradata' => [
989+
'custom',
990+
'workspace-teradata',
991+
1,
992+
null,
993+
null,
994+
['owner' => ['features' => ['dynamic-backend-jobs']]],
995+
];
988996
yield 'custom unknown' => [
989997
'custom',
990998
'unknown',

0 commit comments

Comments
 (0)