Merge pull request #287 from keboola/jv-PST-324-fix-source-tags-validation

[input-mapping] Fix source tags validation

Author: janvanicek

src/Helper/BuildQueryFromConfigurationHelper.php

@@ -10,14 +10,16 @@ class BuildQueryFromConfigurationHelper
 {
     public static function buildQuery(array $configuration): string
     {
-        if (isset($configuration['query']) && isset($configuration['source']['tags'])) {
+        $tagsPresent = count($configuration['source']['tags'] ?? []) > 0;
+
+        if (isset($configuration['query']) && $tagsPresent) {
             return sprintf(
                 '%s AND (%s)',
                 $configuration['query'],
                 self::buildQueryForSourceTags($configuration['source']['tags']),
             );
         }
-        if (isset($configuration['source']['tags'])) {
+        if ($tagsPresent) {
             return self::buildQueryForSourceTags(
                 $configuration['source']['tags'],
                 $configuration['changed_since'] ?? null,

tests/Helper/BuildQueryFromConfigurationHelperTest.php

@@ -117,6 +117,19 @@ public function testBuildQuerySourceTagsAndQuery(): void
         );
     }
 
+    public function testBuildQuerySourceTagsAndQueryWhenSourceTagsEmpty(): void
+    {
+        self::assertEquals(
+            'tag:123',
+            BuildQueryFromConfigurationHelper::buildQuery([
+                'query' => 'tag:123',
+                'source' => [
+                    'tags' => [],
+                ],
+            ]),
+        );
+    }
+
     public function testChangedSinceQueryPortion(): void
     {
         self::assertEquals(