client(_:shouldRetry:error:attempts:): Only one retry attempt is allowed?

[AndrewSB]

i don't understand the docstring next to this function. this is the implementation of the function

private func performRequest<T>(attempts: Int = 1, send: () async throws -> T) async throws -> T {
    do {
        return try await send()
    } catch {
        guard let error = error as? DataLoaderError else {
            throw error
        }
        guard try await delegate.client(self, shouldRetry: error.task, error: error.error, attempts: attempts) else {
            throw error.error
        }
        return try await performRequest(attempts: attempts + 1, send: send)
    }
}

it looks like if i return true from my APIClientDelegate it'll retry forever.

where is the "only one retry attempt" enforcement done? and what do i do if i want to retry once immediately, and then again after 5 seconds, for example

[richardtop]

1. I think, in the delegate you need to check whether it's your 1st or 2nd attempt etc.
2. I think an exponential decay behavior should be either incorporated in the library or be built on top of this library, i.e. a caller of the HTTP client waiting and issuing the request again.

[AndrewSB]

@kean could you confirm? the docs here don't make sense. why is Only one retry attempt is allowed.? afaict i can retry as much as i want

https://kean-docs.github.io/get/documentation/get/apiclientdelegate/client(_:shouldretry:error:attempts:)-4lwvz/

[kean]

"Gets called after a networking failure. Only one retry attempt is allowed." – seems like it's outdated. It was probably written before the attempts parameter was added.

[AndrewSB]

👍

should update the docs, makes sense. i have full control of retry attempts. thanks @kean