lint errors

Author: kdpuvvadi

.github/workflows/lint.yml

@@ -1,14 +1,28 @@
-name: CI
+---
+name: Ansible Lint
 
-on: [push, pull_request]
+'on': [push, pull_request]
 
 jobs:
-  build:
+  lint:
     runs-on: ubuntu-latest
     name: ansible-lint
     steps:
-      - uses: actions/checkout@master
-      - uses: actions/setup-python@v2
-      - run: pip install ansible ansible-lint
-      - run: ansible-lint --version
-      - run: ansible-lint .
+      - name: checkout codebase
+        uses: actions/checkout@master
+
+      - name: setup python
+        uses: actions/setup-python@v2
+        with:
+          python-version: '3.x'
+
+      - name: install dependencies
+        run: pip3 install ansible ansible-lint yamllint
+
+      - name: check ansible-lint version
+        run: ansible-lint --version
+
+      - name: lint
+        run: |
+          ansible-lint .
+          yamllint .

example.vars.yml

@@ -2,3 +2,4 @@
 config_dir: '/home/ansible/omada/'
 omada_url: https://static.tp-link.com/2021/202105/20210507/Omada_SDN_Controller_v4.3.5_linux_x64.tar.gz
 omada_dir: '/home/ansible/omada/'
+mongo_url: https://repo.mongodb.org/yum/redhat/{{ ansible_distribution_major_version }}/mongodb-org/3.6/x86_64/RPMS/mongodb-org-server-3.6.23-1.el{{ ansible_distribution_major_version }}.x86_64.rpm

main.yml

@@ -5,10 +5,10 @@
   pre_tasks:
     - name: vars
       include_vars: vars.yml
-      
+
     - name: install packages
       import_tasks: tasks/packages.yml
-      
+
   tasks:
     - name: download Controller from tplink
       import_tasks: tasks/setup.yml

requirements.yml

@@ -1,3 +1,3 @@
 ---
 collections:
-  - community.general
+  - community.general

tasks/ip.yml

@@ -5,6 +5,6 @@
   register: ip
   when: omada_preset.rc == 0
 
-- name: url 
+- name: url
   debug:
-    msg: "Omada Controller is running at {{ ipify_public_ip }}:8088"
+    msg: "Omada Controller is running at {{ ipify_public_ip }}:8088"

tasks/omada.yml

@@ -1,14 +1,14 @@
 ---
 
 - name: Install Omada
-  become: yes
+  become: 'yes'
   command: install.sh -y -n
   args:
     chdir: /home/ansible/omada/
   register: omadainstall
   when: omada_preset.rc == 1
 
-- name: omada install status 
+- name: omada install status
   debug:
     msg: "{{ omadainstall.stdout_lines }}"
   when: omada_preset.rc == 1
@@ -18,5 +18,3 @@
     name: tpeap
     state: started
     enabled: true
-
-

tasks/packages.yml

@@ -10,24 +10,24 @@
 - name: apt install packages
   apt:
     name:
-    - mongodb
-    - jsvc
-    - curl
-    - openjdk-8-jre-headless
+      - mongodb
+      - jsvc
+      - curl
+      - openjdk-8-jre-headless
     state: present
     cache_valid_time: 3600
   when: ansible_facts.os_family == "Debian"
 
 - name: yum cache update & upgrade
-  yum: 
+  yum:
     name: "*"
     state: latest
     update_cache: true
   when: ansible_facts.os_family == "RedHat"
-  
+
 - name: yum install packages
   yum:
-    name: 
+    name:
       - curl
       - java-1.8.0-openjdk-headless.x86_64
       - jsvc
@@ -37,7 +37,7 @@
 
 - name: Install mongodb from rpm
   yum:
-    name: https://repo.mongodb.org/yum/redhat/{{ ansible_distribution_major_version }}/mongodb-org/3.6/x86_64/RPMS/mongodb-org-server-3.6.23-1.el{{ ansible_distribution_major_version }}.x86_64.rpm
+    name: " {{ mongo_url }} "
     state: present
   when: ansible_facts.os_family == "RedHat"
 
@@ -59,4 +59,4 @@
   failed_when: false
   changed_when: false
   check_mode: false
-  register: omada_preset
+  register: omada_preset

tasks/setup.yml

@@ -1,7 +1,7 @@
 ---
 
 - name: Create Omada Directory "{{ omada_dir }}"
-  file: 
+  file:
     path: "{{ omada_dir }}"
     state: directory
     mode: '0755'
@@ -10,6 +10,6 @@
   unarchive:
     src: "{{ omada_url }}"
     dest: "{{ omada_dir }}"
-    remote_src: yes
-    extra_opts: 
-      --strip-components=1
+    remote_src: 'yes'
+    extra_opts:
+      --strip-components=1