Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing URL doesn't change the query URL #46

Open
Olamuhammed opened this issue Mar 5, 2021 · 1 comment
Open

Changing URL doesn't change the query URL #46

Olamuhammed opened this issue Mar 5, 2021 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Olamuhammed
Copy link
Collaborator

Summary:

  • When a user changes the lookout url, it should in turn change the query url, but doesn't until after a refresh
@Olamuhammed Olamuhammed added the bug Something isn't working label Mar 5, 2021
@kdoran kdoran removed their assignment Mar 8, 2021
@kdoran kdoran added good first issue Good for newcomers help wanted Extra attention is needed labels Mar 8, 2021
@kdoran
Copy link
Owner

kdoran commented Mar 8, 2021

👍
probably need this old trick

componentDidUpdate (prevProps) {
    if (prevProps.match.url !== this.props.match.url) {
      this.load()
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants