Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all warning reported by JShint files linting #13

Open
kdidenko opened this issue Oct 5, 2017 · 1 comment
Open

Fix all warning reported by JShint files linting #13

kdidenko opened this issue Oct 5, 2017 · 1 comment
Assignees
Labels
automation improvement existing features and attributes improving / extending activities task

Comments

@kdidenko
Copy link
Owner

kdidenko commented Oct 5, 2017

There are no errors but project have around 18 warnings, they all must be fixed:

ws1@kdidenko ~/projects/TabSaver/src/tabsaver
$ grunt --force jshint
Running "jshint:build" (jshint) task

src/scripts/dialog.js
  line 94   col 39  Missing semicolon.
  line 31   col 15  Weird construction. Is 'new' necessary?
  line 134  col 1   Missing '()' invoking a constructor.
  line 134  col 2   Missing semicolon.
  line 214  col 13  Unnecessary semicolon.
  line 258  col 49  Functions declared within loops referencing an outer scoped variable may lead to confusing semantics.
  line 339  col 20  Functions declared within loops referencing an outer scoped variable may lead to confusing semantics.
  line 142  col 16  Weird construction. Is 'new' necessary?
  line 374  col 1   Missing '()' invoking a constructor.
  line 430  col 2   Unnecessary semicolon.
  line 440  col 2   Unnecessary semicolon.

src/scripts/identity.js
  line 81   col 47  Missing semicolon.
  line 146  col 37  Misleading line break before '+'; readers may interpret this as an expression boundary.
  line 152  col 29  Misleading line break before '+'; readers may interpret this as an expression boundary.
  line 168  col 6   Missing semicolon.

src/scripts/popup.js
  line 37   col 43  Functions declared within loops referencing an outer scoped variable may lead to confusing semantics.
  line 42   col 2   Unnecessary semicolon.
  line 80   col 33  Confusing use of '!'.

  ‼  18 warnings

Warning: Task "jshint:build" failed. Used --force, continuing.

Done, but with warnings.
@kdidenko kdidenko added automation improvement existing features and attributes improving / extending activities task labels Oct 5, 2017
@kdidenko kdidenko added this to the Project build automation [DevOps] milestone Oct 5, 2017
@kdidenko kdidenko self-assigned this Oct 5, 2017
@kdidenko
Copy link
Owner Author

kdidenko commented Oct 5, 2017

Files having warnings:

  • src/scripts/dialog.js
  • src/scripts/identity.js
  • src/scripts/popup.js

@kdidenko kdidenko added this to To do in [TS] Coding General via automation Feb 16, 2018
@kdidenko kdidenko added this to To do in [TS] Automation via automation Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation improvement existing features and attributes improving / extending activities task
Projects
TabSaver
Awaiting triage
Development

No branches or pull requests

1 participant