Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the code of Dialog's UI view tabs toogling #12

Open
kdidenko opened this issue Sep 7, 2017 · 1 comment
Open

Refactor the code of Dialog's UI view tabs toogling #12

kdidenko opened this issue Sep 7, 2017 · 1 comment
Assignees
Labels
improvement existing features and attributes improving / extending activities task

Comments

@kdidenko
Copy link
Owner

kdidenko commented Sep 7, 2017

See popup.js Lines: 4 - 27

instead of manually "switching off" all previously active tab and switching on the one required, and adding same code blocks for each new tab in the future, changed code must determine which tabs exist, which must be "off" and which to activate automatically

@kdidenko kdidenko added improvement existing features and attributes improving / extending activities task labels Sep 7, 2017
@kdidenko kdidenko self-assigned this Sep 7, 2017
@kdidenko
Copy link
Owner Author

kdidenko commented Sep 7, 2017

all functions with signature like:

function showSaveTab() {
	// switch tabs
        ....
}

must be replaced with a single function of

function showTab('Save') {
        ....
}

@kdidenko kdidenko added this to To do in [TS] Features via automation Feb 16, 2018
@kdidenko kdidenko added this to To do in [TS] Coding General via automation Feb 16, 2018
@kdidenko kdidenko added this to To do in [TS] Migration via automation Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement existing features and attributes improving / extending activities task
Projects
TabSaver
Awaiting triage
[TS] Features
  
To do
[TS] Migration
  
To do
Development

No branches or pull requests

1 participant