Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verification if user is currently logged in to his Google account #1

Open
GoogleCodeExporter opened this issue Jun 18, 2015 · 1 comment
Assignees
Labels
feature improvement existing features and attributes improving / extending activities task

Comments

@GoogleCodeExporter
Copy link

It is required for user to be logged in into Google account in order for 
extension to function. If user is currently no logged in extension should show 
a dialog to login.

Original issue reported on code.google.com by [email protected] on 20 Mar 2014 at 11:57

@kdidenko kdidenko changed the title Add verification if user is currently logged in into hi Google account Add verification if user is currently logged in into his Google account Jan 31, 2016
@kdidenko kdidenko self-assigned this Jan 31, 2016
@kdidenko kdidenko changed the title Add verification if user is currently logged in into his Google account Add verification if user is currently logged in to his Google account Jan 31, 2016
@kdidenko
Copy link
Owner

kdidenko commented Jul 23, 2017

Was implemented long time ago inside a scripts/identity.js lib, even before ES6's Promises were actually supported anywhere (starting from Chrome v.32), while issue haven't been still closed. Now it's already time to:

  1. Rename the file to oauth2-client.js
  2. Implement separate authentication class for each service that user have to be authenticated (it's actually still only his Google Account at the moment, but more to come shortly!)
  3. Refactor the code from long chains of callback based if/else into a Promise -based style
  4. Test it
  5. Close the issue than

@kdidenko kdidenko added improvement existing features and attributes improving / extending activities feature task labels Jul 23, 2017
@kdidenko kdidenko added this to the Version 1.1.15 release milestone Jul 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature improvement existing features and attributes improving / extending activities task
Projects
None yet
Development

No branches or pull requests

2 participants