Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On re-handshake, the client should clear the subscribed channels. #28

Open
mahesh2080 opened this issue Jan 1, 2022 · 1 comment
Open

Comments

@mahesh2080
Copy link

When the server asks for a re-handshake, the client should clear its state, including the subscribed channels.

We added a listener for the handshake event, and in OnMessage, we are calling GetChannel('/topic', lastReplyId).Subscribe(). In the event of a re-handshake, GetChannel returns an existing channel from the Channels dictionary with the previously passed replyId and ignores the replyId in the current #call.

After the handshake, it should clear all non-meta channels from the Channels dictionary.

This bug causes this issue:
##27

@mahesh2080
Copy link
Author

@kdcllc

Please check this fix and let me know if I can create a pull request:

dev...mahesh2080:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant