Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare exceptions as final #342

Open
Art4 opened this issue Dec 29, 2023 · 0 comments
Open

Declare exceptions as final #342

Art4 opened this issue Dec 29, 2023 · 0 comments
Labels
BC break code quality
Milestone
v3.0.0

Comments

@Art4
Copy link
Collaborator

Art4 commented Dec 29, 2023

In #300 and #310 I've missed out to set the new exeptions to final. Doing this now would be a breaking change and will therefore be done in v3.0.0.

  • \Redmine\Exception\ClientException
  • \Redmine\Exception\InvalidApiNameException
  • \Redmine\Exception\InvalidParameterException
  • \Redmine\Exception\MissingParameterException
  • \Redmine\Exception\SerializerException
@Art4 Art4 added this to the v3.0.0 milestone Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BC break code quality
Projects
None yet
Milestone
v3.0.0
Development

No branches or pull requests
1 participant
@Art4