Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parse xlsx without xl/sharedStrings.xml #8

Merged
merged 3 commits into from
Oct 27, 2023
Merged

Fix parse xlsx without xl/sharedStrings.xml #8

merged 3 commits into from
Oct 27, 2023

Conversation

velios
Copy link
Contributor

@velios velios commented Oct 27, 2023

No description provided.

velios
velios commented Oct 27, 2023
View reviewed changes
Copy link
Contributor Author

@velios velios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look at PR when you see fit. If you decide to upload changes to master, please use squash and merge.

@velios
Copy link
Contributor Author

velios commented Oct 27, 2023

@kbosompem Also, if you decide that this is appropriate, then I would send it with a little refactoring of those places that were difficult for me to understand when editing. Let me know if this work is worth sending.

@kbosompem kbosompem merged commit 11342a8 into kbosompem:main Oct 27, 2023
1 check passed
@velios velios deleted the shared-strings-fix branch October 27, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@velios @kbosompem