Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin download process must happen on a temporary file #203

Open
salehkhazaei opened this issue Jun 14, 2024 · 0 comments
Open

Plugin download process must happen on a temporary file #203

salehkhazaei opened this issue Jun 14, 2024 · 0 comments

Comments

@salehkhazaei
Copy link
Contributor

Describe the bug
When downloading a plugin (e.g. updating plugin version) if for any reason plugin download breaks, the plugin binary will be corrupted.
Although config file wont take the effect until after download is completed, we need to make sure that we dont break the plugin binary.
It's better to download the new file into a temporary file and then move it on the plugin binary once download is finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant