Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal does not close after sending a GIF #8

Open
telegrace opened this issue Jun 23, 2022 · 1 comment
Open

Modal does not close after sending a GIF #8

telegrace opened this issue Jun 23, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@telegrace
Copy link

Repro Steps:

  1. In Slack type /search in the message
  2. Select search gifs with trial-1-giphy
  3. Type cat or another other search
  4. Select a channel and continue
  5. Send a gif with the send button
  6. Observe the issue

Suggested Fix:
Once the gif has been sent close the modal.

@kayakapagan kayakapagan self-assigned this Jun 23, 2022
@kayakapagan kayakapagan added the bug Something isn't working label Jun 23, 2022
@kayakapagan
Copy link
Owner

kayakapagan commented Jun 27, 2022

The problem is, slack api is not support to close modal after an action call, for it to be closed, there should be a view_submission, you can find the necessary link here.

We can leave it as it is, or we can change the send button with a selection process and put a send button as a modal submit button. For now, it will stay as it is, later it may be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants