Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total count showing a wrong number when query param kebutuhan exist #581

Closed
Tracked by #110
mazipan opened this issue Aug 7, 2021 · 3 comments · Fixed by #661
Closed
Tracked by #110

Total count showing a wrong number when query param kebutuhan exist #581

mazipan opened this issue Aug 7, 2021 · 3 comments · Fixed by #661
Assignees
Labels
bug Something isn't working

Comments

@mazipan
Copy link
Member

mazipan commented Aug 7, 2021

Description

Screenshot_20210807-185421_Chrome

Expected Behaviour

When have query param ? kebutuhan=, we expect user will only search for certain data in the province list, even they can change the selection on the province detail.

So my expectation also it will show the count of spesific "kebutuhan"

Additional Information

We can work the quick fix for this, but I still prefer if we work on #486 first to make it easier for us differentiate the page.

@mazipan mazipan added the bug Something isn't working label Aug 7, 2021
@mazipan mazipan changed the title Total count show wrong number when query param kebutuhan exist Total count showing a wrong number when query param kebutuhan exist Aug 7, 2021
@nkristoporus
Copy link
Contributor

Hi @mazipan, I have done a little bit of investigation on this particular issue. I found out that the issue is because this page is using unfiltered data from ~/data/wbw-sheets.json which contains all information including Rumah Sakit, Donor Plasma, Ambulans, and others. I can do a quick fix to resolve the issue with the current query param, but if you want to wait for #486 that's fine as well. Let me know your thoughts on this.

@mazipan
Copy link
Member Author

mazipan commented Aug 11, 2021

Yeah, we can do a quick fix for now.
It's a big task if we want to take a proper steps in the current situation.

Can you help us to work on this @nkristoporus ?

@nkristoporus
Copy link
Contributor

Yeah, I will work on this. Thanks 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants