Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regions plugin with enableDragSelection on mobile (multi touch bug) #3780

Open
rodsmyname opened this issue Jul 8, 2024 · 0 comments
Open
Labels

Comments

@rodsmyname
Copy link

Bug description

Simultaneous touches on the wavesurfer with the Regions plugin and enableDragSelection enabled will cause for multiple regions to appear simultaneously and create a region that cannot be removed.

Environment

  • Browser: Chrome
  • Mobile
  • tested on android and iphone same outcome

Minimal code snippet

Preventing touch greater than 1 does not do anything to wavesurfer, I believe it was not designed with multi touch in mind so it does not respond well to it.

const handleTouchStart = (event) => {
  if (event.touches.length > 1) {
    event.preventDefault();
  }
};

const handleTouchMove = (event) => {
  if (event.cancelable) {
    event.preventDefault();
  }
};

window.addEventListener("touchstart", handleTouchStart, { passive: false });
waveSurferRef.current.addEventListener("touchmove", handleTouchMove, {
  passive: false,
});

However the most pressing matter is that it ignores the following, with single touches or mouse clicks everything works perfectly fine (only one region can exist at a time), however with multi touch, multiple regions are created which should not be possible, and these regions for some reason cannot be deleted.

waveSurferInstance.current.on("dragstart", (start) => {
  wsRegions.getRegions().forEach((r) => {
    r.remove();
  });
})

Expected result

Only a single region should exist with the code above and multi touch should be disabled

Obtained result

Regions that cannot be deleted are created and wavesurfer regions does not handle multi touch well

Screenshots

Screenshot_20240708_165802_Samsung Internet

@rodsmyname rodsmyname added the bug label Jul 8, 2024
@rodsmyname rodsmyname changed the title Regions plugin with enableDragSelection on mobile (multi touch big) Regions plugin with enableDragSelection on mobile (multi touch bug) Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant