Skip to content

Commit 39acaaf

Browse files
author
Keisuke KATO
authored
Merge pull request #20 from k--kato/#19
fixed Adds extra param for `Func<T, bool>` #19
2 parents 73cb331 + bef8054 commit 39acaaf

File tree

8 files changed

+58
-20
lines changed

8 files changed

+58
-20
lines changed

.travis.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,11 @@ os:
44
- osx
55
- linux
66

7+
cache:
8+
bundler: true
9+
directories:
10+
- node_modules # NPM packages
11+
712
before_install:
813
- if [ $TRAVIS_OS_NAME == "linux" ]; then
914
export CXX="g++-4.9" CC="gcc-4.9" DISPLAY=:99.0;

CHANGELOG.md

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
# Change Log
2+
3+
## 0.0.8 (December 2, 2016)
4+
5+
* bug fix - Adds extra param for `Func<T, bool>`. See [#19](https://github.com/k--kato/vscode-docomment/issues/19).
6+
7+
## 0.0.7 (July 11, 2016)
8+
9+
## 0.0.6 (Jun 24, 2016)
10+
11+
## 0.0.5 (April 2, 2016)
12+
13+
## 0.0.4 (February 7, 2016)
14+
15+
## 0.0.3 (January 24, 2016)
16+
17+
## 0.0.2 (January 14, 2016)
18+
19+
## 0.0.1 (January 4, 2016)

package.json

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
{
22
"name": "docomment",
3-
"version": "0.0.7",
3+
"version": "0.0.8",
44
"publisher": "k--kato",
55
"engines": {
6-
"vscode": "^1.3.x"
6+
"vscode": "^1.7.x"
77
},
88
"displayName": "C# XML Documentation Comments",
99
"description": "Generate C# XML documentation comments for ///",
@@ -45,20 +45,22 @@
4545
"dependencies": {
4646
},
4747
"devDependencies": {
48-
"typescript": "^1.8.10",
49-
"vscode": "^0.11.14",
50-
"tslint": "^3.13.0",
51-
"istanbul": "^0.4.4",
52-
"coveralls": "^2.11.9",
53-
"mocha": "^2.5.3",
54-
"mocha-lcov-reporter": "^1.2.0"
48+
"typescript": "^2.0.10",
49+
"vscode": "^1.0.3",
50+
"tslint": "^4.0.2",
51+
"istanbul": "^0.4.5",
52+
"coveralls": "^2.11.15",
53+
"mocha": "^3.2.0",
54+
"mocha-lcov-reporter": "^1.2.0",
55+
"@types/node": "^6.0.40",
56+
"@types/mocha": "^2.2.33"
5557
},
5658
"extensionDependencies": [
5759
],
5860
"isAMD": false,
5961
"scripts": {
60-
"vscode:prepublish": "node ./node_modules/vscode/bin/compile",
61-
"compile": "node ./node_modules/vscode/bin/compile -p ./",
62+
"vscode:prepublish": "tsc -p ./",
63+
"compile": "tsc -watch -p ./",
6264
"watch": "node ./node_modules/vscode/bin/compile -watch -p ./",
6365
"test": "node ./node_modules/vscode/bin/test",
6466
"coverage_travis": "./node_modules/istanbul/lib/cli.js cover ./node_modules/mocha/bin/_mocha -- -R spec --ui tdd ./out/test/**/*.js",

src/SyntacticAnalysis/SyntacticAnalysisCSharp.ts

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -96,10 +96,19 @@ export class SyntacticAnalysisCSharp {
9696

9797
let paramName: Array<string> = new Array<string>();
9898
params[1].split(',').forEach(param => {
99-
const hasOptionaParam: boolean = param.match(/\S+\s+\S+\s*=/) !== null;
100-
const name: RegExpMatchArray = (hasOptionaParam)
101-
? param.match(/\S+\s+(\S+)\s*=.*/)
102-
: param.match(/(\S+)\s*$/);
99+
const hasOptionalParam: boolean = param.match(/\S+\s+\S+\s*=/) !== null;
100+
const hasGenericParam: boolean = param.match(/[<]/) !== null;
101+
const hasTypeInfo: boolean = param.match(/[\w\W]+\s+[\w\W]+/) !== null;
102+
let name: RegExpMatchArray = null;
103+
if (hasOptionalParam) {
104+
name = param.match(/\S+\s+(\S+)\s*=.*/);
105+
} else if (hasGenericParam) {
106+
name = null; // SKIP
107+
} else if (!hasTypeInfo) {
108+
name = null; // SKIP
109+
} else {
110+
name = param.match(/(\S+)\s*$/);
111+
}
103112
if (name !== null && name.length === 2) {
104113
paramName.push(name[1]);
105114
}

test/TestData/X.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,5 +27,7 @@ public class Nested{} // "T:N.X.Nested"
2727
[Route("{time}/{location}")]
2828
[HttpGet]
2929
public async Task<string> GetInfoForTime(string location, double time)
30+
public Collection<T> Filter(Func<T, bool> query) { }
31+
public Collection<T> Filter(Func<T, bool> queryFirst, Func<T, U, V> querySecond) { }
3032
}
3133
}

tsconfig.json

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,15 @@
11
{
22
"compilerOptions": {
33
"module": "commonjs",
4-
"target": "es5",
4+
"target": "es6",
55
"outDir": "out",
6-
"noLib": true,
6+
"lib": [
7+
"es6"
8+
],
79
"sourceMap": true
810
},
911
"exclude": [
10-
"node_modules"
12+
"node_modules",
13+
".vscode-test"
1114
]
1215
}

typings/node.d.ts

Lines changed: 0 additions & 1 deletion
This file was deleted.

typings/vscode-typings.d.ts

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)