Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance opportunities #13

Open
rfhh opened this issue Dec 10, 2018 · 0 comments
Open

Performance opportunities #13

rfhh opened this issue Dec 10, 2018 · 0 comments

Comments

@rfhh
Copy link
Collaborator

rfhh commented Dec 10, 2018

callgrind flags some methods in the profile which possibly might be inlined:

  • 7.32% SegmentIterator::next()
  • 7.12% SegmentIterator::hasNext()
  • 7.14% ColumnWriter::add(unsigned long)
  • 4.20% InmemColumnReader::next()
  • 1.30% InmemoryIterator::next() -- not sure, probably virtual
  • 1.64% InmemoryIterator::hasNext() -- not sure, probably virtual
  • 1.77% NewColumnTable::next()

LUMB-32, with rules=LUMB_L (much) extended by me.

The sorting routines and their usage of the heap are also high in the profile. Who's surprised, I would say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant