Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some default values for KeyValue is not working #401

Open
uubulb opened this issue Jul 20, 2024 · 1 comment
Open

some default values for KeyValue is not working #401

uubulb opened this issue Jul 20, 2024 · 1 comment

Comments

@uubulb
Copy link

uubulb commented Jul 20, 2024

According to the document, all Windows service recovery action related options (OnFailure*) have default values. However, the OnFailure option must be specified for these default values to take effect.

if onFailure := ws.Option.string(OnFailure, ""); onFailure != "" {

If OnFailure is not set or is set to an empty string, all related options will be ignored, and the recovery action itself will not be configured.

@QuinnCiccoretti
Copy link

+1 Because of the code above, the actual default behaviour is noaction on failure, while the docs say it would be restart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants