Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify data generation into a single function #25

Open
kangalio opened this issue May 2, 2020 · 0 comments
Open

Unify data generation into a single function #25

kangalio opened this issue May 2, 2020 · 0 comments

Comments

@kangalio
Copy link
Owner

kangalio commented May 2, 2020

Currently each function in data_generators.py iterates over the raw xml file on its own. Datetimes are converted over and over again, no caching. It's probably a bit inefficient, and I think it might also be cleaner to do all the xml analysis in a single place and provide the results in a neat XmlAnalysis class or something. Like it's currently done with replays analysis basically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant