Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support eio #4

Closed
dannypsnl opened this issue Sep 25, 2023 · 2 comments
Closed

support eio #4

dannypsnl opened this issue Sep 25, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@dannypsnl
Copy link

dannypsnl commented Sep 25, 2023 •
edited
Loading

Originally I think the fswatch_lwt and lwt_eio will work, but after I dig into the source code of fswatch_lwt, I believe it will need a direct support fswatch_eio here.

Since niether Async_kernel.Mvar.Read_write.t nor Event.t array Lwt_mvar.t are supported by eio's extension.
@kandu kandu added the enhancement New feature or request label Sep 29, 2023
@kandu
Copy link
Owner

kandu commented Sep 29, 2023

This an interesting functionality, do you want to make a PR to implement it? Or we'll wait for a while since I'm busying in another project for now.

@dannypsnl
Copy link
Author

I'm not having time recently either, I'm fine to wait a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kandu @dannypsnl