Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common-lisp fails to build #660

Closed
kanaka opened this issue Aug 6, 2024 · 1 comment
Closed

common-lisp fails to build #660

kanaka opened this issue Aug 6, 2024 · 1 comment

Comments

@kanaka
Copy link
Owner

kanaka commented Aug 6, 2024

The original docker image for common-lisp uses some checkout/built components. Trying to update things to more modern versions of things causes some issues. The first is that the build doesn't find dependencies. I got common-lisp working on my local system by using sbcl to build instead of cl-launch: 062fb6f.

However, in GHA CI, it crashes right after building the first step: https://github.com/kanaka/mal/actions/runs/10270914448/job/28419731317

As noted in this commit 062fb6f:

The update from ubuntu:vivid to ubuntu:20.04 update the version of sbcl
from 1.2.4.debian to 2.0.1.debian. This resulted in the cl-launch based
build process no longer working: dependencies were not resolved (but
running it several times would eventually resolve them. So use an sbcl
build command directly when building for sbcl.

Note: updating the image to ubuntu:24.04 upgrades the version of sbcl to
2.2.9.debian. Something about that version breaks how we do hash-maps.
They become temperamental: hash-map creation often results in a nil
object returned and doing (get hm key) usually results in nil returned
even if the key shows as being present.

@iqbalansari I know it's been a long time since you created this implementation, but any chance you would be able to look at this issue and try and resolve it?

@kanaka
Copy link
Owner Author

kanaka commented Aug 15, 2024

Updated to Ubuntu 24.04 and hash-map issue fixed in 412e50e

@kanaka kanaka closed this as completed Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant