Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we use v before the version number in tags? #159

Closed
kennycallado opened this issue Mar 20, 2022 · 2 comments
Closed

Should we use v before the version number in tags? #159

kennycallado opened this issue Mar 20, 2022 · 2 comments

Comments

@kennycallado
Copy link
Contributor

Hi!

I'm working on PR #102 and I was wondering if we should start using v before the version number when tag a version. It's almost an standard and could be one of the problem why PR #102 doesn't work.

Reference to semantic versioning:
https://semver.org/#is-v123-a-semantic-version

I have checked different ways...
https://github.com/kennycallado/joshuto-1/releases
@kamiyaa
Copy link
Owner

kamiyaa commented Mar 21, 2022 •
edited
Loading

Yeah, switching to vx.y.z is fine with me

@kamiyaa
Copy link
Owner

kamiyaa commented Apr 9, 2022

Closing via #160 ?

@kamiyaa kamiyaa closed this as completed Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kennycallado @kamiyaa