-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON Schema doesn't allow headers
for schema
#765
Comments
Experiencing the same issue |
Hi @benkroeger and thank you for the report Sorry but I'm not adding a lot here but just labeling it according to our new Contribution Guide and issue flow. It seems already got into Now in order to advance to Also we would love to PR to update the schema. Thank you and sorry that this comment is not a complete solution (yet). |
@benkroeger @paleite @zifeo @kevinalh @illarionvk @BasixKOR @frehner @franzwilhelm Hey guys, sorry for a long time in fixing this problem. I mentioned all of you because you had this problem, so you can test it on your configs, and maybe you have some suggestions for the next major of |
Note: You can test this by using custom schema options on VS Code YAML extension like this: "yaml.schemas": {
"https://unpkg.com/[email protected]/config-schema.json": "graphql.config.*"
} |
@BasixKOR thanks, available in |
Describe the bug
According to the documentation, you can pass headers to a schema url - and the feature itself actually works.
It's just that the provided json schema throws a validation error because it expects schema to either be a string or an array of strings
To Reproduce
set schema to
yaml schema validation against
https://unpkg.com/[email protected]/config-schema.json
will report the issue as follows:Expected behavior
the documented format should be allowed in the json schema
Environment:
Additional context
The text was updated successfully, but these errors were encountered: