Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISO Tag: doc comment PhotographicSensitivity? #20

Open
sharnoff opened this issue Jan 3, 2022 · 2 comments
Open

ISO Tag: doc comment PhotographicSensitivity? #20

sharnoff opened this issue Jan 3, 2022 · 2 comments

Comments

@sharnoff
Copy link
Contributor

sharnoff commented Jan 3, 2022

After searching for the tag corresponding to the camera's ISO, the exiftool source has some enlightening comments about the PhotographicSensitivity tag:

https://github.com/exiftool/exiftool/blob/74dbab1d2766d6422bb05b033ac6634bf8d1f582/lib/Image/ExifTool/Exif.pm#L1942-L1952

(Data from my own camera(s) seems to back this up). In light of that, would it be possible to add a doc comment to indicate that Tag::PhotographicSensitivity is actually just ISO? -- the name chosen in the EXIF 2.3 spec is not very intuitive.

I'm happy to submit a PR myself, just wanted to check whether it was something you'd be in favor of.

@kamadak
Copy link
Owner

kamadak commented Sep 3, 2022

Annex G of the Exif standard describes the rationale for the use of sensitivity-related tags. Calling PhotographicSensitivity just ISO speed seems too simplistic.

That said, I agree that a doc comment would be helpful for users, so I will consider adding some explanation.

@kamadak
Copy link
Owner

kamadak commented Sep 7, 2022

I have added some comments in commit 1b44282. I hope this helps users to find sensitivity-related tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants