Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update_self fails to compile for more unusual targets #223

Open
pufferfish101007 opened this issue Dec 31, 2024 · 1 comment
Open

update_self fails to compile for more unusual targets #223

pufferfish101007 opened this issue Dec 31, 2024 · 1 comment
Labels
enhancement New feature or request internal-improvements Related to internal publishing, building, workflows, formatting & linting

Comments

@pufferfish101007
Copy link

I happened to be working on my (android) phone using Termux, and ezno was throwing up an error because the #[cfg(target_os = ...)]s in update_self in src/utilities.rs don't cover every possible case. I fixed compilation by adding an additional cfg statement for "android" which allowed it to compile but probably doesn't work.

I'd suggest that perhaps for the case where target_os is not windows, mac or linux that update_self is stubbed out for a no-op function so that things compile on slightly more exotoc platforms, although other, nicer solutions may exist.

@kaleidawave
Copy link
Owner

kaleidawave commented Jan 1, 2025

Ah yes that allows for ezno experimental upgrade which updates the binary in place with the latest version from GitHub releases. It is only needed for the CLI so shouldn't break anything. Will add it under CFG in #220

@kaleidawave kaleidawave added enhancement New feature or request internal-improvements Related to internal publishing, building, workflows, formatting & linting labels Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internal-improvements Related to internal publishing, building, workflows, formatting & linting
Projects
None yet
Development

No branches or pull requests

2 participants