Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot get the same evaluation SI-SNRi, even if using the pretrained model #22

Open
deciding opened this issue Dec 29, 2019 · 4 comments

Comments

@deciding
Copy link

deciding commented Dec 29, 2019

Hi, thanks for the code and the pretrained model, they really help me a lot!

When I trying to use your pretrained model provided in the link pan.baidu.com/s/1-Rqm7GwpV7Cc1XzHSpHROg, I found that, when running the evaluate.py, the result is very different from your evaluate.log.
In the evaluate.log, it appears "Average SISNR improvement: 15.45"
However, when I run it, it is around 9.8

I assume that, we should have the same json files in data/tt/. In this case, we have the same code and same weights, we should have the same SISNRi 15.45.
I am wondering what makes the difference. Could I know the commit id of your repo when you run the evaluate.py. And could I have a look at your data/tt/mix.json(maybe just the starting 10 lines)

Below are the first few lines of my data/tt/mix.json
[ [ "datasets/data/wsj0-mix/2speakers/wav8k/min/tt/mix/445c0206_0.60431_22gc0105_-0.60431.wav", 33301 ], [ "datasets/data/wsj0-mix/2speakers/wav8k/min/tt/mix/420c020h_1.1139_442c0203_-1.1139.wav", 51541 ], [ "datasets/data/wsj0-mix/2speakers/wav8k/min/tt/mix/22go0107_0.079969_051c010u_-0.079969.wav", 30391 ], [ "datasets/data/wsj0-mix/2speakers/wav8k/min/tt/mix/444o0314_2.1819_053o020e_-2.1819.wav", 25624 ], [ "datasets/data/wsj0-mix/2speakers/wav8k/min/tt/mix/423o0304_1.419_420c020x_-1.419.wav", 48961 ], [ "datasets/data/wsj0-mix/2speakers/wav8k/min/tt/mix/423o030b_1.4753_053o0209_-1.4753.wav", 44774 ], [ "datasets/data/wsj0-mix/2speakers/wav8k/min/tt/mix/441o030o_1.9903_445c020y_-1.9903.wav", 26795 ], [ "datasets/data/wsj0-mix/2speakers/wav8k/min/tt/mix/22ga010u_0.43921_443o030l_-0.43921.wav", 45120 ],

If this is not our difference, what other possibilities are there? Thanks!

@kaituoxu
Copy link
Owner

I can't visit my json files anymore.
Maybe you can check your librosa version?

@deciding
Copy link
Author

I can't visit my json files anymore.
Maybe you can check your librosa version?

Thanks for the hint. Can I have a look at your conv-tasnet pip freeze? maybe I can have a check on it?

@Tinglok
Copy link

Tinglok commented Feb 7, 2020

I can't visit my json files anymore.
Maybe you can check your librosa version?

Thanks for the hint. Can I have a look at your conv-tasnet pip freeze? maybe I can have a check on it?

Hi deciding,

Have you solved this problem? Because I have this problem too. Thanks!

@enk100
Copy link

enk100 commented Feb 7, 2020

So apparently, WSJ has two version of each file - .wv1 & .wv2
one is a noisier version of the another. use the clean ones and then you be able to reproduce the results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants