kaiax/auction: Introduce auction module #288
Conversation
hyeonLewis
force-pushed
the
feat/auction
branch
9 times, most recently
from
58e8bb8 to
8c98bed
Compare
|
@hyunsooda As this PR becomes too large, I think merging this first would be better. If it's ok, please let me know. Thanks. |
hyeonLewis
changed the title
hyeonLewis
force-pushed
the
feat/auction
branch
2 times, most recently
from
496b11b to
7dc1490
Compare
hyeonLewis
requested review from
blukat29,
yoomee1313 and
ian0371
as code owners
hyeonLewis
changed the title
hyeonLewis
force-pushed
the
feat/auction
branch
from
760c5ed to
0bd99f0
Compare
hyeonLewis
force-pushed
the
feat/auction
branch
from
3ab9364 to
96910c4
Compare
hyeonLewis
force-pushed
the
feat/auction
branch
from
96910c4 to
a704f5f
Compare
blockchain/system/auction.go
Outdated
| ret, err := caller.Auctioneer(opts) | ||
| if err != nil { | ||
| return common.Address{}, err | ||
| } | ||
|
|
||
| return ret, nil |
There was a problem hiding this comment.
| ret, err := caller.Auctioneer(opts) | |
| if err != nil { | |
| return common.Address{}, err | |
| } | |
| return ret, nil | |
| return caller.Auctioneer(opts) |
blockchain/types/transaction.go
Outdated
| @@ -293,6 +293,10 @@ func (tx *Transaction) setDecoded(inner TxInternalData, size int) { | |||
| } | |||
| } | |||
|
|
|||
| func (tx *Transaction) UpdateTime() { | |||
There was a problem hiding this comment.
Nit: Would SetTime be better?
| @@ -0,0 +1,220 @@ | |||
| // Copyright 2025 The Kaia Authors | |||
There was a problem hiding this comment.
I think separating the EIP712 logic and bid functionality into two files would make it more concise.
kaiax/auction/bid.go
Outdated
| func (b *Bid) ValidateSearcherSig(chainId *big.Int, verifyingContract common.Address) error { | ||
| if chainId == nil { | ||
| return errors.New("chainId is nil") | ||
| } | ||
|
|
||
| if verifyingContract == (common.Address{}) { | ||
| return errors.New("verifyingContract is empty") | ||
| } | ||
|
|
||
| digest := b.GetHashTypedData(chainId, verifyingContract) | ||
|
|
||
| // Manually convert V from 27/28 to 0/1 | ||
| sig := slices.Clone(b.SearcherSig) | ||
| if sig[crypto.RecoveryIDOffset] == 27 || sig[crypto.RecoveryIDOffset] == 28 { | ||
| sig[crypto.RecoveryIDOffset] -= 27 | ||
| } | ||
|
|
||
| pub, err := crypto.SigToPub(digest, sig) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to recover searcher sig: %v", err) | ||
| } | ||
|
|
||
| recoveredSender := crypto.PubkeyToAddress(*pub) | ||
| if recoveredSender != b.Sender { | ||
| return fmt.Errorf("invalid searcher sig: expected %v, calculated %v", b.Sender, recoveredSender) | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| func (b *Bid) ValidateAuctioneerSig(auctioneer common.Address) error { | ||
| digest := b.GetEthSignedMessageHash() | ||
|
|
||
| // Manually convert V from 27/28 to 0/1 | ||
| sig := slices.Clone(b.AuctioneerSig) | ||
| if sig[crypto.RecoveryIDOffset] == 27 || sig[crypto.RecoveryIDOffset] == 28 { | ||
| sig[crypto.RecoveryIDOffset] -= 27 | ||
| } | ||
|
|
||
| pub, err := crypto.SigToPub(digest, sig) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to recover auctioneer sig: %v", err) | ||
| } | ||
|
|
||
| recoveredAuctioneer := crypto.PubkeyToAddress(*pub) | ||
| if recoveredAuctioneer != auctioneer { | ||
| return fmt.Errorf("invalid auctioneer sig: expected %v, calculated %v", auctioneer, recoveredAuctioneer) | ||
| } | ||
|
|
||
| return nil | ||
| } |
There was a problem hiding this comment.
Can you extract recovering the sender's address into another function and call it to make it more concise?
There was a problem hiding this comment.
Do you expect function like CheckRecoveredAddress(pubKey, expectedAddr) bool?
kaiax/auction/bid.go
Outdated
| return errors.New("chainId is nil") | ||
| } | ||
|
|
||
| if verifyingContract == (common.Address{}) { | ||
| return errors.New("verifyingContract is empty") |
There was a problem hiding this comment.
Two errors can be moved to errors.go
| return bp | ||
| } | ||
|
|
||
| func (bp *BidPool) SubscribeNewBid(sink chan<- *auction.Bid) event.Subscription { |
There was a problem hiding this comment.
How do you expect where this function is utilized in future?
There was a problem hiding this comment.
It'll be used in protocol manger to broadcast new bids.
|
|
||
| if i == 0 { | ||
| // if first transaction exceeds deadline, remove the address | ||
| delete(txs, addr) |
There was a problem hiding this comment.
Nit: can we remove it after all iteration?
Q: Is it assumed that txs are ordered in time ascending? TransactionsByPriceAndNonce may not guarantee.
There was a problem hiding this comment.
We don't need the time-ordered one, but enough with nonce-ordered.
Proposed changes
This PR introduces
kaiax/auctionmodule for the implementation of KIP-249.Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
I have read the CLA Document and I hereby sign the CLAin first time contribute$ make test)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...