Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FE: Editing an existing filter doesn't have the CEL syntax help info available #622

Open
Haarolean opened this issue Oct 18, 2024 · 1 comment · May be fixed by #646
Open

FE: Editing an existing filter doesn't have the CEL syntax help info available #622

Haarolean opened this issue Oct 18, 2024 · 1 comment · May be fixed by #646
Assignees
@pisal-shubham
Labels
area/messages good first issue Up for grabs hacktoberfest Issues good for hacktoberfest goal scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature
Milestone
1.1

Comments

@Haarolean
Copy link
Member

When creating a filter there's quick info on CEL filters available when clicking on the question mark button:
image
But one is missing when editing an existing filter:
image
TODO:

  • add the same button for filter editing modal
@Haarolean Haarolean added good first issue Up for grabs type/enhancement En enhancement/improvement to an already existing feature scope/frontend Related to frontend changes hacktoberfest Issues good for hacktoberfest goal area/messages labels Oct 18, 2024
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Oct 18, 2024
@pisal-shubham
Copy link

Hello @Haarolean I will like to work on this issue. Can you please assign it to me ?

@Haarolean Haarolean moved this from Todo to In Development in Up for grabs Oct 30, 2024
@Haarolean Haarolean mentioned this issue Oct 30, 2024
Closed
4 tasks
pisal-shubham added a commit to pisal-shubham/kafka-ui that referenced this issue Nov 5, 2024
@pisal-shubham
Closes kafbat/kafka-ui kafbat#622
b1dc56e
@pisal-shubham pisal-shubham linked a pull request Nov 5, 2024 that will close this issue
Open
13 tasks
@Haarolean Haarolean moved this from In Development to PR Approved in Up for grabs Nov 17, 2024
@Haarolean Haarolean added this to the 1.1 milestone Nov 17, 2024
@Haarolean Haarolean moved this from Todo to PR Approved in Release 1.1 Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pisal-shubham pisal-shubham

Labels
area/messages good first issue Up for grabs hacktoberfest Issues good for hacktoberfest goal scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature
Projects
Release 1.1
Status: PR Approved
Up for grabs
Status: PR Approved
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

FE: Filters: Display CEL help when editing filter pisal-shubham/kafka-ui
2 participants
@Haarolean @pisal-shubham