Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data AND Error #19

Open
astanciu opened this issue Nov 3, 2016 · 0 comments
Open

Data AND Error #19

astanciu opened this issue Nov 3, 2016 · 0 comments

Comments

@astanciu
Copy link

astanciu commented Nov 3, 2016

Not sure if I'm missing something but it seems the library is flat out erroring on queries that return partial data with errors:

{
  "data": {
    "requests": [
      {
        "uuid": "fc8b7a62-1234-4119-bc88-132543723ea9",
        "created_at": "2016-10-29T19:16:27.361Z",
        "status": "COMPLETED",
        "notes": null,
        "number": 10,
      }
    ]
  },
  "errors": [
    {
      "name": "TooManyResultsError",
      "message": "Bad resource",
      "statusCode": 500
    }
  ]
}

I would expect the above result to both trigger a transport error, but also pass the data along instead of null:
https://github.com/kadirahq/lokka-transport-http/blob/master/lib/index.js#L84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant